chore(detectors): Prevent Query Injection detector from running on SQL queries #96690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #96690 +/- ##
===========================================
+ Coverage 66.12% 80.66% +14.53%
===========================================
Files 8465 8481 +16
Lines 372806 373635 +829
Branches 24205 24205
===========================================
+ Hits 246521 301387 +54866
+ Misses 125912 71875 -54037
Partials 373 373 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
|
||
| sql_keywords = ("SELECT", "UPDATE", "INSERT") | ||
| if any(description.upper().startswith(keyword) for keyword in sql_keywords): | ||
| return False |
There was a problem hiding this comment.
Bug: SQL Exclusion Flaws: DELETE Missing, Whitespace Ignored
The sql_keywords tuple, intended to exclude common SQL queries from query injection detection, is missing "DELETE", a fundamental DML operation. This omission means "DELETE" queries are not excluded, leading to inconsistent behavior. Additionally, the keyword check does not account for leading whitespace in the span description, allowing queries like " SELECT * FROM users" to bypass the exclusion filter and still be processed by the detector, defeating its purpose of preventing false positives for common SQL operations.
JoshFerge
approved these changes
Jul 30, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 4, 2025
…L queries (#96690) fixes an edge case where some oddly formed SQL requests were getting picked up by the query injection detector (not the sql injection one)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes an edge case where some oddly formed SQL requests were getting picked up by the query injection detector (not the sql injection one)